Nightly build is failing due version conflict between storage datalak… - #8635
Conversation
…e and storage blob
|
Can one of the admins verify this patch? |
|
@xiafu-msft , @rakshith91 , @lmazuel : Can you please take a look and let me know if this change in setup.py to update the dependency is fine. Currently nightly build is failing due to this dependency against azure-storage-blob 12.0.0 version and current dev version is 12.1.0b1 |
|
I think we don't want to change the version to "azure-storage-blob>=12.0.0". That is super dangerous when there is breaking changes in azure-storage-blob>=13.0.0 |
| "azure-core<2.0.0,>=1.0.0", | ||
| "msrest>=0.6.10", | ||
| "azure-storage-blob~=12.0.0" | ||
| "azure-storage-blob<13.0.0,>=12.0.0" |
There was a problem hiding this comment.
Thanks for adding the upper bound！😊
While I still have some concern:
1）is 12.0.0b1 > 12.0.0? I’m not very sure(I’m worried this commit is not fixing the problem)
2) What’s the purpose of nightly build? Is it to run test for all packages in live? Currently azure-storage-file-datalake depends on exactly bob 12.0.0, so 12.0.0b1 will break the tests for datalake package. Because there are a lot of breaking changes between 12.0.0 and 12.0.0b1
3) azure-storage-blob is GA now, why are we still using 12.0.0b1?
| #override azure-storage-file-share msrest>=0.6.10 | ||
| #override azure-storage-file-datalake msrest>=0.6.10 | ||
| #override azure-storage-file-datalake azure-storage-blob~=12.0.0 | ||
| #override azure-storage-file-datalake azure-storage-blob~=12.0 |
There was a problem hiding this comment.
Why is it necessary to touch the version here?
Could we upgrade the version of nightly build to 12.0.0 instead of using the preview version?
|
Sorry that the comment wasn’t sent out successfully.. I didn’t notice that before you merge 😂 |
|
I think the commit probably will not fix the nightly build? |
|
Given that:
Here's the relevant section from the packaging docs:
So your package shouldn't eliminate the dev version of blob that was installed prior. Does this make sense? Praveen has also run a local test run to confirm Laurent's suggestion :) If it doesn't work, we will definitely adjust and try again! |
* InteractiveBrowserCredential prompts for account selection (#8470) * remove *.yaml under tests folder from manifest.in (#8625) * [AutoPR] cosmos-db/resource-manager (#8560) * regenerated * fix script * another place * fix * fix * one more change * one more * undo multiapi script * regeneated * undo multiapi script * history, version + additional fix * regenerated * fixed test * fixed generation mistake * added more breaking changes to history * regenerated again * additional fixes * udpated test names * test recordings * Update README.md (#8628) Add standard section on security issues below the "file an issue via GitHub Issues' bullet. * Handle exceptions when constructing DefaultAzureCredential (#8294) * Python 3.8 test pipeline is not cancelled when build is cancelled (#8544) * Skip python 3.8 testing when CI is cancelled * Cosmos docstring review (#8607) * cosmos docstring edits * user-defined * trailing whitespace * xfail flaky emulator tests * review feedback * Default credentials are configurable by kwargs (#8514) * Nightly build is failing due version conflict between storage datalak… (#8635) * Nightly build is failing due version conflict between storage datalake and storage blob * InkRecognizer to use GA azure-core (#8341) * InkRecognizer to use Ga azure-core * Disable auto-pr update * Azconfig remove tests from whl (#8663) * update tests * ignoring the azure folder directly (#8673)
6 participants
Azure-storage-file-datalake has dependency to 12.0.0 as per setup.py and causing to install 12.0.0 version of azure-storage-blob during nightly build global test instead of latest 12.1.0b1 and causing test failures for new test cases added for azure-storage-blob.
Fix is to update azure-storage-blob dependency to >=12.0.0 in azure-storage-file-datalake